mirrors/CyberChef
1
0
Fork 0
mirror of https://github.com/gchq/CyberChef.git synced 2025-04-24 00:36:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Efficiency improvements to reduce unnecessary casting

Browse source
This commit is contained in:
n1474335 2022-09-02 20:15:07 +01:00
parent 16b79e32f6
commit 406da9fa2c
3 changed files with 31 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/core/Utils.mjs
View file

@ -407,6 +407,7 @@ class Utils {
*/
static strToArrayBuffer(str) {
log.debug("Converting string to array buffer");
if (!str) return new ArrayBuffer;
const arr = new Uint8Array(str.length);
let i = str.length, b;
while (i--) {
@ -434,6 +435,7 @@ class Utils {
*/
static strToUtf8ArrayBuffer(str) {
log.debug("Converting string to UTF8 array buffer");
if (!str) return new ArrayBuffer;
const utf8Str = utf8.encode(str);
if (str.length !== utf8Str.length) {
@ -464,6 +466,7 @@ class Utils {
*/
static strToByteArray(str) {
log.debug("Converting string to byte array");
if (!str) return [];
const byteArray = new Array(str.length);
let i = str.length, b;
while (i--) {
@ -491,6 +494,7 @@ class Utils {
*/
static strToUtf8ByteArray(str) {
log.debug("Converting string to UTF8 byte array");
if (!str) return [];
const utf8Str = utf8.encode(str);
if (str.length !== utf8Str.length) {
@ -520,6 +524,7 @@ class Utils {
*/
static strToCharcode(str) {
log.debug("Converting string to charcode");
if (!str) return [];
const charcode = [];
for (let i = 0; i < str.length; i++) {
@ -555,6 +560,7 @@ class Utils {
*/
static byteArrayToUtf8(byteArray) {
log.debug("Converting byte array to UTF8");
if (!byteArray || !byteArray.length) return "";
const str = Utils.byteArrayToChars(byteArray);
try {
const utf8Str = utf8.decode(str);
@ -588,7 +594,7 @@ class Utils {
*/
static byteArrayToChars(byteArray) {
log.debug("Converting byte array to chars");
if (!byteArray) return "";
if (!byteArray || !byteArray.length) return "";
let str = "";
// String concatenation appears to be faster than an array join
for (let i = 0; i < byteArray.length;) {
@ -611,6 +617,7 @@ class Utils {
*/
static arrayBufferToStr(arrayBuffer, utf8=true) {
log.debug("Converting array buffer to str");
if (!arrayBuffer || !arrayBuffer.byteLength) return "";
const arr = new Uint8Array(arrayBuffer);
return utf8 ? Utils.byteArrayToUtf8(arr) : Utils.byteArrayToChars(arr);
}