mirrors/CyberChef
1
0
Fork 0
mirror of https://github.com/gchq/CyberChef.git synced 2025-04-23 16:26:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

'JSON to CSV' operation now escapes characters correctly. Added tests for CSV/JSON operations.

Browse source
This commit is contained in:
n1474335 2018-11-13 17:54:43 +00:00
parent 863bdffa84
commit 3a979b6cda
3 changed files with 232 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

58
src/core/operations/JSONToCSV.mjs
View file

@ -20,7 +20,7 @@ class JSONToCSV extends Operation {
this.name = "JSON to CSV";
this.module = "Default";
this.description = "Converts JSON data to a CSV.";
this.description = "Converts JSON data to a CSV based on the definition in RFC 4180.";
this.infoURL = "https://wikipedia.org/wiki/Comma-separated_values";
this.inputType = "JSON";
this.outputType = "string";
@ -46,27 +46,67 @@ class JSONToCSV extends Operation {
run(input, args) {
const [cellDelim, rowDelim] = args;
this.cellDelim = cellDelim;
this.rowDelim = rowDelim;
const self = this;
// TODO: Escape cells correctly.
try {
// If the JSON is an array of arrays, this is easy
if (input[0] instanceof Array) {
return input.map(row => row.join(cellDelim)).join(rowDelim) + rowDelim;
return input
.map(row => row
.map(self.escapeCellContents.bind(self))
.join(cellDelim)
)
.join(rowDelim) +
rowDelim;
}
// If it's an array of dictionaries...
const header = Object.keys(input[0]);
return header.join(cellDelim) +
return header
.map(self.escapeCellContents.bind(self))
.join(cellDelim) +
rowDelim +
input.map(
row => header.map(
h => row[h]
).join(cellDelim)
).join(rowDelim) +
input
.map(row => header
.map(h => row[h])
.map(self.escapeCellContents.bind(self))
.join(cellDelim)
)
.join(rowDelim) +
rowDelim;
} catch (err) {
throw new OperationError("Unable to parse JSON to CSV: " + err);
throw new OperationError("Unable to parse JSON to CSV: " + err.toString());
}
}
/**
* Correctly escapes a cell's contents based on the cell and row delimiters.
*
* @param {string} data
* @returns {string}
*/
escapeCellContents(data) {
// Double quotes should be doubled up
data = data.replace(/"/g, '""');
// If the cell contains a cell or row delimiter or a double quote, it mut be enclosed in double quotes
if (
data.indexOf(this.cellDelim) >= 0 ||
data.indexOf(this.rowDelim) >= 0 ||
data.indexOf("\n") >= 0 ||
data.indexOf("\r") >= 0 ||
data.indexOf('"') >= 0
) {
data = `"${data}"`;
}
return data;
}
}
export default JSONToCSV;