From 1fd72363bd38b305ef00835d353a4ecce11a8165 Mon Sep 17 00:00:00 2001 From: Robin Scholtes Date: Thu, 20 Apr 2023 21:05:44 +1200 Subject: [PATCH] [#181] remove calcControlsHeight as the component is always 70px in height now, and it caused issues on mobile UI. It's become obsolete --- src/web/App.mjs | 1 - src/web/TODO.md | 3 --- src/web/waiters/ControlsWaiter.mjs | 12 ------------ 3 files changed, 16 deletions(-) diff --git a/src/web/App.mjs b/src/web/App.mjs index 76562488..1957e797 100755 --- a/src/web/App.mjs +++ b/src/web/App.mjs @@ -668,7 +668,6 @@ class App { this.manager.recipe.adjustWidth(); this.manager.input.calcMaxTabs(); this.manager.output.calcMaxTabs(); - this.manager.controls.calcControlsHeight(); //@TODO } diff --git a/src/web/TODO.md b/src/web/TODO.md index 4d3faff1..a1e08a7a 100644 --- a/src/web/TODO.md +++ b/src/web/TODO.md @@ -12,9 +12,6 @@ - test drag and drop etc. Regular mobile events / UX ### Desktop UI: -#### Bug -- `calcControlsHeight` and `adjustComponentSizes` cause trouble in `recipe` `rec-list` when resizing from desktop to mobile - ### General UI: - fix up key / tab events so UI can be navigated comfortably with keys ( inc. visual focus feedback ). Probably a lot of work though diff --git a/src/web/waiters/ControlsWaiter.mjs b/src/web/waiters/ControlsWaiter.mjs index 6a0ef6f2..a86cce79 100755 --- a/src/web/waiters/ControlsWaiter.mjs +++ b/src/web/waiters/ControlsWaiter.mjs @@ -418,18 +418,6 @@ ${navigator.userAgent} bakeButton.classList.add("btn-success"); } } - - /** - * Calculates the height of the controls area and adjusts the recipe - * height accordingly. - */ - calcControlsHeight() { - const controls = document.getElementById("controls"), - recList = document.getElementById("rec-list"); - - recList.style.bottom = controls.clientHeight + "px"; - } - } export default ControlsWaiter;